search

thealeksandr / PFLockScreen-Android

Apache License 2.0
223 stars 84 forks source link

UI issue #24

Open RudraNirvan opened 5 years ago

RudraNirvan commented 5 years ago

image

Is there some styling that needs to be added?

thealeksandr commented 5 years ago

@RudraNirvan Shouldn't be like that. Could you give me more info about what you did?

MaximKulikov commented 5 years ago

@RudraNirvan I got simular result when set android:background = white for theme in manifest for that activity.

MaximKulikov commented 5 years ago

@thealeksandr I found fragment_lock_screen_pf.xml line:19 -> android:paddingBottom="60dp". What was the idea to separate those content from bottom button with 60 dp?

thealeksandr commented 5 years ago

@MaximKulikov can you give me more details how you get the above result? What's the problem with the padding?

MaximKulikov commented 5 years ago

@thealeksandr I figure, i can put fragment_lock_screen_pf.xml in project res and it override layout from library, so i can do with button whatether i want, so it not issue anymore.

meidikawardana commented 4 years ago

any progress on this issue? I got this issue, & I suspect this is something related with app / activity theme. I am using Theme.MaterialComponents from this gradle:

implementation 'com.google.android.material:material:1.1.0-beta01'

maybe you can reproduce this issue with that theme, @thealeksandr

thealeksandr commented 4 years ago

@meidikawardana I wasn't able to reproduce. Can you provide me more details? what android version? Can you reproduce on emulator? Have you tried to update library?

meidikawardana commented 4 years ago

@thealeksandr I created a sample project for reproduce this issue. looks like you need to create a custom theme for activity too. and add background color white to that activity theme. but importantly, the app theme must be Theme.MaterialComponents . Here is my sample: https://drive.google.com/open?id=1Ir5_HPA9rVOBHYTVOXx_kntGQjK6J0B7

thealeksandr commented 4 years ago

@meidikawardana looking into it

thealeksandr commented 4 years ago

@meidikawardana @RudraNirvan @MaximKulikov from the demo above I found that this can happen when there's this line for theme style<item name="android:background">#fff</item>. This line shouldn't be used in theme style. This will basically override backgrounds for all elements inside activity where background not set

meidikawardana commented 4 years ago

ok, thank you for your response @thealeksandr