search

thealeksandr / PFLockScreen-Android

Apache License 2.0
223 stars 84 forks source link

UI for Landscape orientation makes no sense #36

Open GocePetrovski opened 5 years ago

GocePetrovski commented 5 years ago

Having the Title and the dots indicators on the right side as the user types the PIN make no sense from UX point of view. If fact, I thing Landscape mode for PIN entry screen makes no sense if the feedback of the data entry (the dots or whatever they are called) is not right above the "keyboard". Having extra data (if needed) on the right may justify Landscape mode but what data will you put in there? If others want this, would be good to be able to disable it.

thealeksandr commented 5 years ago

@GocePetrovski I added landscape mode because some one asked me to. I personaly don't think if it's necessary. But if someone need it I think it's good to have. If you telling it's bad UX, I would appreciate suggestion for improvements. Also I didn't came up with it myself. This type of layout pretty common for lanscape mode. One of the example you can see in Galaxy S10+. Screen is big enough to provide lanscape mode. But not big enough to put all elements vertically. You can disable landcape mode for your activity in manifest or programatiaclly.

GocePetrovski commented 5 years ago

Reason why is bad UX is that if holding tablet with left hand and typing with right hand, the input (the dots) is covered by the hand. Input fields, of input feedback, should always be visible and in obvious (above the keyboard) place. If user gets interrupted, by someone talking to him/her, when glancing back at the screen he/she doesn't know how many characters/numbers has already entered because the dots are either covered or not in obvious place. On iOS for example, this kind of screens we always force them to be portrait only and on tablets they always fit in landscape anyway. Beta 4 fitted perfectly in landscape on the tablets I'm testing. I'm sure more compact keyboard for small tablets would be fine. Numeric keyboard provided by Android fits in landscape and still has room for other UI elements above, right? My activity has to be in landscape, but this fragment (unless I put it in another activity) just doesn't work for us. If you must have dedicated landscape mode I will suggest finding a way to keep the dots above the keyboard. Maybe do 2 rows keyboard? Top row numbers bottom other buttons and elements? I'm just thinking out loud not sure this would be good without trying it.