Joystick support and Error handling in case of error with relative imports

thealphadollar / brkout

A game made using PyGame under CodeClub as a learning project.

MIT License

8 stars 19 forks source link

Joystick support and Error handling in case of error with relative imports #45

Closed prashantramnani closed 5 years ago

thealphadollar commented 5 years ago

@prashantramnani It'll take me some time to test this, please work on other issues in the meantime.

P.S. Please resolve the merge conflict.

prashantramnani commented 5 years ago

Conflict Has been Resolved

prashantramnani commented 5 years ago

Any reviews?

thealphadollar commented 5 years ago

I already gave one 3 days ago.

The joystick changes looks great to me, thanks a lot @prashantramnani

I would request you to update the README.md accordingly and also add the joystick with which the changes have been tested in the README.md

thealphadollar commented 5 years ago

ping @prashantramnani

thealphadollar commented 5 years ago

@prashantramnani Please resolve the conflict.

prashantramnani commented 5 years ago

Done, please review @thealphadollar

prashantramnani commented 5 years ago

I have no clue where that file came from, but I'll remove it

amrit-choudhary commented 5 years ago

@prashantramnani Hi, I have created an input package which handles the keyboard inputs. It's easier to use than the default pygame system. Do you want to work together and add joystick support for that? My package can be found here: https://github.com/vineetjc/pygame-Coin-Fall-/tree/master/src/input_package

prashantramnani commented 5 years ago

Yeah sure @amrit-choudhary