search

theam / aws-lambda-haskell-runtime

⚡Haskell runtime for AWS Lambda
https://theam.github.io/aws-lambda-haskell-runtime/
Other
269 stars 48 forks source link

Support aeson-2.0 #121

Closed nomeata closed 1 year ago

nomeata commented 2 years ago

fixes #120.

Following the advice in https://github.com/haskell/aeson/issues/881#issuecomment-944920664.

It compiles, did not do any more checks.

nomeata commented 2 years ago

Does this need to be backward compatible?

maerten commented 1 year ago

This PR fixes the issue for me 👍 using stack ; ghc9.2.4 ; stackage nightly-2022-09-12

NickSeagull commented 1 year ago

Was about to merge+publish this, but between this one and #122 , which one should we use?

nomeata commented 1 year ago

Or is the .cabal file autogenerated in thus repo? (Haven't worked with package.yaml yet) In that case my change is a bit futile, is it?

seanhess commented 1 year ago

I'm jumping in to make some changes to an old project and hitting this issue. Any idea when this might be released? How can I help?

NickSeagull commented 1 year ago

Working on merging this, thanks for being patient with the long delays 😅

NickSeagull commented 1 year ago

Thanks for this, I've opened a PR with this PR's contents in order to add some CICD checks too. #124.

Closing this one in order to merge the other one

NickSeagull commented 1 year ago

Just so you know 1.4.2 has been published with Aeson 2.0 support