theangryangel / logstash-output-jdbc

JDBC output for Logstash
MIT License
256 stars 101 forks source link

add docker container pull link in readme #144

Closed delatitude closed 5 years ago

delatitude commented 5 years ago

It would be easy if one can get hands on a ready made container with every thing installed for this plugin. Logstash: 6.5.4; JRE : 42.1.4 Here is code to dockerfile of container image. https://github.com/delatitude/logstash-postgresql-output/blob/master/Dockerfile

theangryangel commented 5 years ago

First off thank you for the PR.

Unfortunately I’m not really sure of the benefit here, if I’m honest..

To be useful for everyone there would either need to be one large docker container bundling jars of random versions for every JDBC driver (Postgres, MySQL, SQLite, etc.)

Or we need a dockerfile for each database engine.

I’m happy to add this as a sample in the documentation, but I’m not sure how useful it is as a Dockerfile in the root of the project. Especially as it’s very very short and specifically for Postgres

Additionally not having any control I would not want to recommend a docker image with little traceability.