theantnest / bccaddress

Bitcoin Cash Address Generator
MIT License
80 stars 49 forks source link

Prefix all addresses and private keys with 'bitcoincash:' #20

Closed zquestz closed 6 years ago

zquestz commented 6 years ago

After reading this article https://www.yours.org/content/increasing-merchant-adoption-of-bitcoin-cash-e3167e2fa326 I realized that we didn't prefix addresses and keys with bitcoincash: and that wallets might scan them as bitcoin addresses/keys.

This PR updates all generated QR codes to add the bitcoincash: scheme, and resizes the QR codes so they fit nicely in the layout.

PLEASE test and confirm this is working as expected and that the layouts look good. I will not merge until I get verification from others that this PR is ready!

Items tested: 1) Default Single Wallet 2) Default Paper Wallet 3) BIP38 Encrypted Paper Wallet. 4) Hidden art Paper Wallets (BIP38 and regular).

zquestz commented 6 years ago

This change is now live. =)