[Feature] Updated to use cashaddr addresses

theantnest / bccaddress

Bitcoin Cash Address Generator

MIT License

80 stars 49 forks source link

[Feature] Updated to use cashaddr addresses #26

Closed zquestz closed 6 years ago

zquestz commented 6 years ago

I have updated everything to present cashaddr style addresses. The only tab I didn't update was the Vanity Wallet, since it requires the old format, and is pretty neat.

All QR codes should now use cashaddr.
The paper wallet discards the 'bitcoincash:' prefix to save space, but the QR codes are for the full address.
Updated BCH donation addresses to cashaddr style.
Removed prefix from private key QR codes to fix sweeps.

Please review, would love to get this rockin.

NOTE: Using https://github.com/bitcoincashjs/bchaddrjs for the conversions.

DesWurstes commented 6 years ago

Hi, I'm working on a Pull Request to cashaddrjs. It'll remove the big number dependency, and the source code will be much smaller. Would you be able to update this file if my Pull Request gets merged?

zquestz commented 6 years ago

I am open to using a more lightweight library. I think this should merge and we can always update it later. 😀

zquestz commented 6 years ago

@theantnest @daftspunk please review!

CreativeName4 commented 6 years ago

Reviewed, looks good! thanks @zquestz !!

imaginaryusername commented 6 years ago

Can confirm, private keys are now good to scan using Bitcoin.com wallet. Tested in single key, paper wallet.

zquestz commented 6 years ago

Going to merge this, thanks for the reviews folks =)