Closed fmontesino closed 4 years ago
Merging #15 into main will decrease coverage by
6.13%
. The diff coverage is4.25%
.
@@ Coverage Diff @@
## main #15 +/- ##
============================================
- Coverage 40.11% 33.98% -6.14%
- Complexity 35 38 +3
============================================
Files 16 16
Lines 172 206 +34
Branches 14 23 +9
============================================
+ Hits 69 70 +1
- Misses 102 135 +33
Partials 1 1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...oggle/feature/manager/view/ProxyManagerFragment.kt | 0.00% <0.00%> (ø) |
0.00 <0.00> (ø) |
|
...inandcarta/create/proxytoggle/view/MainActivity.kt | 6.66% <ø> (+0.41%) |
0.00 <0.00> (ø) |
|
...carta/create/proxytoggle/android/ProxyValidator.kt | 100.00% <100.00%> (ø) |
7.00 <5.00> (+2.00) |
|
...feature/manager/viewmodel/ProxyManagerViewModel.kt | 100.00% <100.00%> (ø) |
8.00 <1.00> (+1.00) |
Please note this is not the final UI and everything is due to be changed. I just felt this PR was getting big enough already and I am still waiting for more designs.
Why?
We have the first draft of the design, so it's a good time to start implementing some UI features.
What?
Bonus
Added some more proxy validation rules. Some screenshots:
![image](https://user-images.githubusercontent.com/1481183/86769535-330e2f00-c047-11ea-920e-a4fca986c05e.png)