search

theappbusiness / android-proxy-toggle

Small application to help android developers to quickly enable and disable proxy settings
MIT License
425 stars 59 forks source link

Move compose state to viewmodel #35

Closed christos-christidis closed 1 year ago

christos-christidis commented 1 year ago

This PR moves the whole app to Compose without changing the logic (viewModel) and breaks up the app into modules, in the 1st commit. In the 2nd commit, composables are made state-less with all logic moved to the viewmodel.

Besides that, there's a lot of refactoring, updating of libs, fixing of errors, modernization of architecture etc.

christos-christidis commented 1 year ago

Screenshot are great but have you considered reducing their number a bit? E.g. your main screen screenshots include icons such as info, and there's a separate screenshot just for the info icon - does that bring value on its own?

Yeah I think we could remove stuff that is already included in main screen. And only let those stuff which is not, like error states of textfields etc..