Closed cbruno10 closed 2 years ago
@cbruno10 thanks for this, it really helps get things in shape!
Config File:
baseurl
for base_url
.Docs:
keycloak_user.md
have been separated so that they'll be individual code blocks when published.General:
Tables:
TODO
comments were addressed in #13 I merely forgot to remove the comments.Thanks @graza-io ! The changes look great, from my perspective the plugin looks good to go.
Thanks @graza-io for another great plugin! I took a look today and left some suggestions/questions below, please let me know if you have any questions on them.
Config file:
baseurl
tobase_url
to follow the standard snake casing?Docs:
#FCA121
correct? It seems to be more orange, not sure if that was copy and paste from another plugin?keycloak_user.md
, can you please break up the middle examples into individual examples, e.g.,Get a specific user by ID
,Get a specific user by username
,Get a specific user by email
? This allows users to copy and paste as the hub site has a copy icon per code block (in the top right of each code block).keycloak_client
andkeycloak_group
, are light on examples. Can you please add a few more so each table doc has at least 3-4 examples? These really help users get started and jump right into using your plugin.General:
limit
clause if given and if it's lower than the default paging size or limit, e.g., https://github.com/turbot/steampipe-plugin-tfe/blob/main/tfe/table_tfe_team.go#L48-L59, as this will help reduce the number of results returned (helpful especially for large APIs).Tables:
keycloak_user
table. Are you planning on adding these before publishing the initial version?keycloak_group
andkeycloak_user
. Are there more columns we can add to both? For instance, for thekeycloak_user
table, in the SDK and API, it seems like there are more potential columns we can add based on what's returned by the API, but I don't see those in the table definition.BriefRepresentation
astrue
. Is there a reason these tables are only fetching this form of information? I only quickly read over the API docs, so I'm not very familiar with it yet, but for these tables, is it better to have the brief or full representations?