search

theasp / docker-novnc

noVNC Display Container for Docker
MIT License
274 stars 153 forks source link

Publish for multiple architectures? #5

Open rgov opened 1 year ago

rgov commented 1 year ago

There isn't a NoVNC container image published to Docker Hub that supports arm64 (e.g., new Macs or Raspberry Pis). (The treehouse/novnc image is completely, and honestly quite impressively, broken.)

I was able to build yours and run it just fine on a Raspberry Pi 4. It would be great if you could publish the images for multiple platforms so it doesn't have to be rebuilt.

You would need to tweak your CircleCI config to use docker buildx build, something like this:

docker buildx build --platform linux/amd64,linux/arm64 --push -t theasp/novnc:latest -f Dockerfile .

The downside is that you have to build and push in a single step. And you probably need to figure out how to configure qemu-user-static and binfmt_msc -- not sure how easy that is to do on CircleCI.

EyedBread commented 10 months ago

Any updates regarding if there is any ready-to-go NoVNC container that support arm64 architectures?

theasp commented 10 months ago

Sorry, I have no plans to provide this image for other architectures. I don't even use this anymore.