Nukebro

[Ericzklm]

Working though the Nukebro backlog. Good news is that the hard part should be finished and the remaining ones should all be documented in the form of a TRB graphic.

One issue that popped up is with the Nukebro vs. Samurott strat, the test is currently disabled:

• Grafaiai Doodles Shell Armor onto everyone
• Samurott clears abilities
• One turn passes
• All raiders have their original abilities restored instead of Shell Armor

[theastrogoth]

One issue that popped up is with the Nukebro vs. Samurott strat, the test is currently disabled:

• Grafaiai Doodles Shell Armor onto everyone
• Samurott clears abilities
• One turn passes
• All raiders have their original abilities restored instead of Shell Armor

For some reason, I had the impression that this is the correct behavior. In the clip, Samurott doesn't land any moves that would be guaranteed crits. I should probably remember what happens from failed Pure Power + AP attempts, but I'm not sure.

If it turns out that Shell Armor should be restored here, we can either:

1) add one more field for ability storage per raider, bringing us up to 3:

• the current ability Pokemon.ability (which is set to "(No Ability)" when nullified)
• the original ability Raider.originalAbility (to be restored upon fainting)
• the ability that was held just prior to nullification, maybe Raider.nullifiedAbility, to be restored when nullification ends

OR

2) Make it so that the Pokemon.ability field isn't changed when nullification happens, but instead take into account Raider.abilityNullified for all ability checks everywhere.

In any case, I would be fine with use the "Average Case" for this strat, since it's on the longer side and we're not accounting for possible misses anyways.

[Ericzklm]

Yea it's hard to draw any conclusions from the corresponding video clip so it's probably fine to keep the implementation as is unless told otherwise.