theastropath / turbot

A Discord bot for tracking Animal Crossing: New Horizons turnip prices and fossil collections
MIT License
8 stars 1 forks source link

Don't munge song titles #166

Closed lexicalunit closed 4 years ago

lexicalunit commented 4 years ago

Depends on #165 being merged first

I didn't like that in turbot's output all the names of songs were munged. Café K.K. became cafe k.k. for example. It just didn't look nice. This PR fixes that issue. Songs are stored in their canonical form, meaning capitalization and unicode are preserved.

⚠️ THIS MEANS EXISTING DB FILES MUST BE MIGRATED ⚠️

Migration is handled automatically by turbot the first time it is run and only applied once. It keeps track of applied migrations in db/migrations.txt.

This PR also lets people leave off the K.K part of the song when they collect/uncollect it. They also don't have to worry about capitalization or accents, same as before.

Screen Shot 2020-05-10 at 1 38 46 PM

codecov-io commented 4 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           99       109   +10     
  Branches        10        13    +3     
=========================================
+ Hits            99       109   +10     
Impacted Files Coverage Δ
src/turbot/assets.py 100.00% <100.00%> (ø)
src/turbot/data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1a6def...b474b55. Read the comment docs.