theaterpedia / crearis-nuxt

2 stars 1 forks source link

N-25 enhance columns/column #25

Open crearis opened 3 months ago

crearis commented 3 months ago

TODO

Need to find a way to make the image fill the column-height and make this feature available as prop of the column

Context

I made additions to colums + column (see my last commit 326ea703b04509f6dd5cbc834aa4f246701e94d9)

Examples

I target these "media-list-items": https://dasei.eu/ausbildung-theaterpaedagogik/grundlagenbildung

Inspect current implementation via pnpm dev:home > ausbildung-theaterpaedagogik/grundlagenbildung

murisceman commented 3 months ago

Button usage

A short notice regarding the use of the button-tmp component in Markdown documents. I changed:

https://github.com/theaterpedia/crearis-nuxt/blob/069e20c0323bd05792adc6adb340b0967212f2d2/apps/home/content/ausbildung-theaterpaedagogik/grundlagen.md?plain=1#L21-L23

to this:

https://github.com/theaterpedia/crearis-nuxt/blob/09c4321acaa0e654c9caa8c530e2704605b8120f/apps/home/content/ausbildung-theaterpaedagogik/grundlagen.md?plain=1#L21-L23

In the first example, an <a> element was nested inside a <button>. Now, the default tag for button-tmp has been changed to NuxtLink, so you only need to forward the to prop to make it work. The original Button component from the ui remains unchanged and still defaults to the button HTML tag.

Additionally, I removed the paragraphs Nuxt Content creates on line breaks within the button.

murisceman commented 3 months ago

Update

Column

Columns

Markdown

Old:

https://github.com/theaterpedia/crearis-nuxt/blob/09c4321acaa0e654c9caa8c530e2704605b8120f/apps/home/content/ausbildung-theaterpaedagogik/grundlagen.md?plain=1#L11-L15

New:

https://github.com/theaterpedia/crearis-nuxt/blob/d78052e6709c0cd3ad469811e47ea8df129926c6/apps/home/content/ausbildung-theaterpaedagogik/grundlagen.md?plain=1#L11-L15

Notes

crearis commented 3 months ago

Great work!

I had just realized on my own that my updates with the padding/gap on colums/column from today morning don't make sense at all, are not needed. I poorly understood your implementation.

So yes let's revert it.