search

theatlantic / django-nested-admin

Django admin classes that allow for nested inlines
http://django-nested-admin.readthedocs.org/
Other
715 stars 99 forks source link

add show_change_link to grappelli_inline_tabular #174

Closed Safrone closed 4 years ago

Safrone commented 4 years ago

addresses: https://github.com/theatlantic/django-nested-admin/issues/173

copied logic from https://github.com/sehmaschine/django-grappelli/blob/master/grappelli/templates/admin/edit_inline/tabular.html#L67

codecov[bot] commented 4 years ago

Codecov Report

Merging #174 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files          19       19           
  Lines        2362     2362           
=======================================
  Hits         1957     1957           
  Misses        405      405
Flag Coverage Δ
#javascript 79.40% <ø> (ø)
#python 88.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 384547f...5fee72c. Read the comment docs.

fdintino commented 4 years ago

Thank you for this!

It looks like grappelli_stacked.html needs this fix as well. Do you think you could add that?

Safrone commented 4 years ago

@fdintino Thanks for catching that. I updated the PR

demerzel21 commented 4 years ago

This would be great!