Add initial tools for managing derivations and React compatibility

theatre-js / theatre

Motion design editor for the web

https://www.theatrejs.com

Apache License 2.0

10.86k stars 338 forks source link

Closed colelawrence closed 1 year ago

colelawrence commented 1 year ago

Initial tools for using dataverse derivations in more places to enable fewer re-renders.

Foundation for #197

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
theatre-playground	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 5:08PM (UTC)

vezwork commented 1 year ago

Very cool PR

+1 to a rename of deriveChild. deriveEl seems okay (although, does it work with any element or only Styled ones? Maybe it should be called deriveStyledEl? Or styledElFromDerivedProps?)
example code inlined in the jsdoc would help me understand the differences between these a lot faster.

vezwork commented 1 year ago

I like the changes to dataverse too

colelawrence commented 1 year ago

Re-requested Aria for the review of dataverse changes.

AriaMinaei commented 1 year ago

@colelawrence couple of unresolved comments remain. Feel free to merge after addressing them.