search

theatre-js / theatre

Motion design editor for the web
https://www.theatrejs.com
Apache License 2.0
10.86k stars 338 forks source link

"File Prop" Type #408

Closed joaogsleite closed 9 months ago

joaogsleite commented 1 year ago

There is already an "Image" Prop Type but it is not possible to select other file types besides images.

With this new "File" Prop Type, it will be possible to select any file type.

Example use case:

Select glb file to change model.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
theatre-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 0:56am
AriaMinaei commented 1 year ago

This is a great PR. Thank you @joaogsleite! I'll review this week.

AriaMinaei commented 1 year ago

/release insiders

github-actions[bot] commented 1 year ago
🎉 Released an insiders' build to npm. Here is how to upgrade: * 🚧 This is an insiders' build. It possibly **is not stable and _may_ corrupt your data**. Always **backup your work** before upgrading. * If you do try this build, welcome aboard, insider 😉. If you're feeling generous, share some feedback here or on [`#contributing`](https://discord.com/channels/870988717190426644/940301611023073400) at Discord. * 🔼 To upgrade, edit `package.json` and replace the versions of all `@theatre` or `theatric` packages with their new versions: ```diff --- @theatre/core: "old-version", +++ @theatre/core: "0.6.1-insiders.4c37567", --- @theatre/studio: "old-version", +++ @theatre/studio: "0.6.1-insiders.4c37567", --- @theatre/dataverse: "old-version", +++ @theatre/dataverse: "0.6.1-insiders.4c37567", --- @theatre/react: "old-version", +++ @theatre/react: "0.6.1-insiders.4c37567", --- @theatre/browser-bundles: "old-version", +++ @theatre/browser-bundles: "0.6.1-insiders.4c37567", --- @theatre/r3f: "old-version", +++ @theatre/r3f: "0.6.1-insiders.4c37567", --- theatric: "old-version", +++ theatric: "0.6.1-insiders.4c37567", ``` All published packages are on npm: * [`@theatre/core@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/core/v/0.6.1-insiders.4c37567) * [`@theatre/studio@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/studio/v/0.6.1-insiders.4c37567) * [`@theatre/dataverse@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/dataverse/v/0.6.1-insiders.4c37567) * [`@theatre/react@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/react/v/0.6.1-insiders.4c37567) * [`@theatre/browser-bundles@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/browser-bundles/v/0.6.1-insiders.4c37567) * [`@theatre/r3f@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/@theatre/r3f/v/0.6.1-insiders.4c37567) * [`theatric@0.6.1-insiders.4c37567`](https://www.npmjs.com/package/theatric/v/0.6.1-insiders.4c37567) Published at the request of @AriaMinaei, on commit ba3cdfcbd47bb4ec703a688f59b1efceac4d01ac. Workflow log [here](https://github.com/theatre-js/theatre/actions/runs/4420820014) to debug.
akre54 commented 9 months ago

This looks great! In addition to 3d models we'd love to use this for importing data like CSVs or JSONs. Would love to see this merged!

AriaMinaei commented 9 months ago

Merged. Thank you @joaogsleite :)