search

thebaer / MMRA

Make Medium Readable Again — a browser extension
https://makemediumreadable.com
MIT License
667 stars 31 forks source link

Update manifest permissions to match medium url #22

Closed rtelicak closed 6 years ago

rtelicak commented 6 years ago

Hi! This if statement 

if (document.querySelector('head meta[property="al:ios:app_name"][content="medium"]')) {
...
}

is no longer working, because they changed head meta tag to be ... content="Medium" .. (note the uppercase M), so the content script won't fire at all.

I've changed required permissions, its not good practice to ask permissions to all pages anyway.

thebaer commented 6 years ago

Hey, thanks for catching this and submitting the pull request! The only problem is that this means the extension won't work on custom domain publications, like https://hackernoon.com/.

I know it's not the best to ask permission for all sites, but I think the solution suggested in #15 is the best way to go. Feel free to tackle that if you want!

thebaer commented 6 years ago

Closing now. Best solution will be implementing #15.