search

thebaer / MMRA

Make Medium Readable Again — a browser extension
https://makemediumreadable.com
MIT License
667 stars 31 forks source link

Fix medium detection #41

Closed dangh closed 5 years ago

dangh commented 5 years ago

The old detection doesn't work on custom domain websites since medium only populate meta tag after the extension loaded.

Fix #40

thebaer commented 5 years ago

Hey, thanks for the PR, but I'm not seeing that issue on the URL in #40. The HTML of the page still includes the meta tag for me. Do you have a URL you've tested on and seen that the detection isn't working?

dangh commented 5 years ago

Sorry my bad 🤦‍♂️ It's working well in Chrome but Safari 12 due to another issue. At the time the content script loaded, the document head/body is null so the detection failed. See: https://developer.apple.com/documentation/safariservices/safari_app_extensions/injecting_a_script_into_a_webpage#2958109

Closing now.