search

thebaselab / codeapp

Building a full-fledged code editor for iPad
https://code.thebaselab.com
MIT License
2.95k stars 202 forks source link

Support for Azure DevOps Repos #118

Closed ChrisTav424 closed 3 years ago

ChrisTav424 commented 3 years ago

This app looks like exactly what I'm after but I'm currently using Azure DevOps Repos rather than GitHub. Are there any plans to support these?

1B1091E4-E0A0-434B-9FB9-9A5B3DFEAAA6

bummoblizard commented 3 years ago

The app should support any git server. Did you add your credentials in the settings page? It can be done by Settings > Version Control > Authentication.

ChrisTav424 commented 3 years ago

I hadn't found the authentication option in settings when I posted this. I now get the following after using credentials

1CD13175-F732-44EF-91CA-2034C2323C3A

I also created a public repo in Azure DevOps for testing :)

https://ctav@dev.azure.com/ctav/test-public/_git/test-public

bummoblizard commented 3 years ago

Confirmed and thanks for the report! I am working on a fix.

ChrisTav424 commented 3 years ago

Blimey, that's some impressive support! 😀

Thank you @bummoblizard!

bummoblizard commented 3 years ago

Fix committed: https://github.com/thebaselab/codeapp-source/commit/e46959085a604598af5fb25457a62440dd9fd26a

ChrisTav424 commented 3 years ago

Just tested, works perfectly! Thank you for fixing it so quickly :)

Can I ask what was wrong? Just interested in how Azure DevOps differs from GitHub :)

bummoblizard commented 3 years ago

Just tested, works perfectly! Thank you for fixing it so quickly :)

Can I ask what was wrong? Just interested in how Azure DevOps differs from GitHub :)

When cloning from GitHub, a suffix .git is needed at the end of the url. For example: https://github.com/thebaselab/codeapp.git

To mimic the behaviour of cli git, which allows cloning using https://github.com/thebaselab/codeapp, .git is appended to the end of the repository url. It turns out that this is not standardised and will fail on Azure Devops. So I removed this logic.

ChrisTav424 commented 3 years ago

Ah that makes sense, thanks for sharing :)