search

thebaselab / codeapp

Building a full-fledged code editor for iPad
https://code.thebaselab.com
MIT License
2.82k stars 188 forks source link

Yarn #172

Open OlshaMB opened 3 years ago

OlshaMB commented 3 years ago

Please make support for yarn.

Ryorama commented 3 years ago

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

bummoblizard commented 3 years ago

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

I'm not sure if @OlshaMB means yarn as the package manager. Anyway, let me know if you need any help on the Java port!

Ryorama commented 3 years ago

Thought I give a quick update on this. If you mean yarn as in the fabricmc gradle plugin, now that the project is open source I’ve started adding support for gradle and more Java support. Once it’s finished, I’ll do a PR for it and if/when it’s merged I’ll reply once again so you know that’s it’s ready

I'm not sure if @OlshaMB means yarn as the package manager. Anyway, let me know if you need any help on the Java port!

Ah, ok. Also, thanks for bringing that up as I do need some quick help with that. What classes as well in what spots in those classes would I need to edit in order to add LSP support for Java. I’m having trouble locating them so if you could tell me that would be greatly appreciated.

bummoblizard commented 3 years ago

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.

Would the LSP be communicating through stdio or websocket?

Ryorama commented 3 years ago

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes.

Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

bummoblizard commented 3 years ago

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes. Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

Ryorama commented 3 years ago

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes. Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

I didn’t, but there is a port out there already for iOS that I’m going to use.

bummoblizard commented 3 years ago

LSP support is not on the repo yet. I'll need to rebuild https://github.com/thebaselab/codeapp/tree/main/CodeApp/monaco-textmate.bundle and add the proper interfaces as well as the related Swift classes. Would the LSP be communicating through stdio or websocket?

Ok. I was just going to add it into the editor for now and I’ll try to figure out the web socket out later on.

Did you manage to port OpenJDK / JRE already?

I didn’t, but there is a port out there already for iOS that I’m going to use.

Great! Let me know if you make it work. I will work on the interface for adding LSP.

It will probably look something like this:

App.registerLanguageService(lang: .java, command: "command-to-launch-LSP")
bummoblizard commented 1 year ago

Yarn blocker: fs.copyFile always fail. Investigation in node source code needed.

bummoblizard commented 1 year ago

Ref: https://github.com/libuv/libuv/issues/3187

We need to modify libuv and rebuild nodejs to fix this.