thebergamo / react-native-fbsdk-next

MIT License
667 stars 166 forks source link

On ANDROID: FacebookRequestErrorClassification in com.facebook.internal package causes Crash. #419

Closed andreipatza closed 1 year ago

andreipatza commented 1 year ago

🐛 Bug Report

Our production app started to crash on android since 1 week. The problem is related to react-native-fbsdk-next. If I remove locally the library from project I can rebuild it, but without facebook login, of course.

The app crashes on startup, without any modifications, in production..

To Reproduce

Just try to install react-native-fbsdk-next on a fresh app. For now, the app on android crashes at startup with the bellow reror:

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.json.JSONArray.length()' on a null object reference at com.facebook.internal.FacebookRequestErrorClassification$Companion.parseJSONDefinition(FacebookRequestErrorClassification.kt:118) at com.facebook.internal.FacebookRequestErrorClassification$Companion.createFromJSON(FacebookRequestErrorClassification.kt:166) at com.facebook.internal.FetchedAppSettingsManager.parseAppSettingsFromJSON$facebook_core_release(FetchedAppSettingsManager.kt:225) at com.facebook.internal.FetchedAppSettingsManager.loadAppSettingsAsync$lambda-0(FetchedAppSettingsManager.kt:129) at com.facebook.internal.FetchedAppSettingsManager.$r8$lambda$0Zs5KScD9YcdRdfqSQiSgW_MgdQ(Unknown Source:0) at com.facebook.internal.FetchedAppSettingsManager$$ExternalSyntheticLambda0.run(Unknown Source:6) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:923)

Expected Behavior

App should work as it worked since this bug appears, app is in production.

Code Example

Environment

info Fetching system and libraries information... (node:94779) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency (Use node --trace-warnings ... to show where the warning was created) System: OS: macOS 13.1 CPU: (10) arm64 Apple M1 Max Memory: 124.97 MB / 32.00 GB Shell: 5.8.1 - /bin/zsh Binaries: Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node Yarn: 1.22.19 - ~/Documents/WORK/FE_NATIVE/dsu-fe/node_modules/.bin/yarn npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm Watchman: 2023.04.03.00 - /opt/homebrew/bin/watchman Managers: CocoaPods: 1.12.0 - /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5 Android SDK: Android NDK: 22.1.7171670 IDEs: Android Studio: 2021.2 AI-212.5712.43.2112.8609683 Xcode: 13.4/13F17a - /usr/bin/xcodebuild Languages: Java: 17.0.4.1 - /usr/bin/javac npmPackages: @react-native-community/cli: Not Found react: 18.0.0 => 18.0.0 react-native: ^0.70.6 => 0.70.6 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.