search

thebergamo / react-native-fbsdk-next

MIT License
633 stars 165 forks source link

FB SDK version Needs upgrade (upstream issue it seems, does not seem to affect functionality) #476

Closed userlab-luisdeleon closed 2 months ago

userlab-luisdeleon commented 5 months ago

🐛 Bug Report

in latest version react-native-fbsdk-next: 12.1.1

image

I have installed the latest version when I integrate it and check the FB console I get this message any ideas?

AronBe commented 5 months ago

Seeing the same

mikehardy commented 5 months ago

I think someone needs to propose a PR that integrates the latest SDK and confirm they have tested it and it works. It's open source, you are a fully empowered developer, not just a powerless user waiting for someone to help you. I'm happy to merge and release any reasonable PR if you can show you've tested it and it works

jamesrogers93 commented 5 months ago

I'm seeing the same issue. Annoyingly this is blocking us from running Facebook ads.

A temporary fix might be to downgrade to use v11.3.0 as it uses FBSDK v15. (I believe this is a bug with FBSDK v16).

Will let you know if this works for me.

jamesrogers93 commented 5 months ago

Now works after downgrading to v11.3.0

Before: Screenshot 2023-11-21 at 12 33 01

After:

Screenshot 2023-11-21 at 14 02 23
mikehardy commented 5 months ago

@jamesrogers93 or....

I think someone needs to propose a PR that integrates the latest SDK and confirm they have tested it and it works.

jamesrogers93 commented 5 months ago

I suggested it as a temporary fix, not a permanent fix.

mikehardy commented 5 months ago

No one wants to do the work to try to move things forward 😆 Not picking on you specifically, this is the tragedy of open source encapsulated in one single issue Everyone interested, no one moving it forward. Eventually someone will really need it then it'll move

CedYF commented 4 months ago

still have this issue

alzalabany commented 3 months ago

feb 2024 :) still same issue

mikehardy commented 3 months ago

Still comments that don't advance anything but they generate notifications for everyone, smiley

4yki commented 2 months ago

Seems like there is an issue with native facebook-android-sdk https://github.com/facebook/facebook-android-sdk/issues/1191 No clear answers from contributors yet... Anyway there is nothing to do with RN package. I think this issue must be closed as it's not an actual library issue. I don't use much functionality (just events tracking) so for me simple patch with downgraded SDK versions works. Not sure if it affects other features.

mikehardy commented 2 months ago

Nice find @4yki thanks for going upstream and looking there. I did my best upstream with a comment trying to move it forward for real, we'll see how it goes.

Agreed this is not a problem we can resolve here so I am going to close this but for anyone reading along that doesn't mean it is solved necessarily it just means there will be no change in the repository here related to the problem, so it doesn't help to keep it open here

If I'm wrong, can always reopen but please do your homework, search lists, check code, really try to understand things and advance them before posting comments. Just posting +1s and metoos is childish behavior in my opinion - generates notifications that have no content which is basically spam. Don't be that person. Thank you :-)