thebergamo / react-native-fbsdk-next

MIT License
633 stars 165 forks source link

feat(Expo): bump Expo Adapters version from 13.0 to 13.4 #482

Closed mihailapuste closed 1 month ago

mihailapuste commented 4 months ago

Bumped iOS deployment target to 13.4 to support expo sdk 50

mikehardy commented 3 months ago

I am unsure why supporting a new version of Expo requires a breaking change in the expo adapters for all expo users? 🤔

mihailapuste commented 3 months ago

@mikehardy Sorry for the late reply! That absolutely makes sense, no reason to merge with breaking changes for now. I've personally forked for my own needs. However I thought of perhaps leaving his here, perhaps it will be needed, and if not, please feel free to close.

Expo 50 now has a minimum deployment target of 13.4

Notable breaking changes iOS minimum deployment target bumped to 13.4.

I will also look into a potential solution to support both if I can find one, open to any suggestions or ideas in the time being.

Thank you !

mikehardy commented 3 months ago

There are easier ways I think? I do something like this to line up my targets, in my Podfile

min_ios_version_supported = '13.4'

post_install do |installer|

  # ...lots of stuff

  installer.pods_project.targets.each do |target|

    target.build_configurations.each do |config|

      # Quiets all the noise about misaligned deployment targets
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = min_ios_version_supported
    end
  end

  # ...anything else you might need

end
mihailapuste commented 2 months ago

There are easier ways I think? I do something like this to line up my targets, in my Podfile

min_ios_version_supported = '13.4'

post_install do |installer|

  # ...lots of stuff

  installer.pods_project.targets.each do |target|

    target.build_configurations.each do |config|

      # Quiets all the noise about misaligned deployment targets
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = min_ios_version_supported
    end
  end

  # ...anything else you might need

end

This seems to have done the trick. Thank you for your help 🚀 @mikehardy

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.