search

thebergamo / react-native-fbsdk-next

MIT License
633 stars 165 forks source link

chore: bump iOS SDK version to 17.0.0 #506

Closed efstathiosntonas closed 3 weeks ago

efstathiosntonas commented 1 month ago

16.3.1 version has issues with Xcode 15.3:

efstathiosntonas commented 3 weeks ago

@thebergamo besides the building issues, version 17 supports the new requirements for Apple privacy manifests.

joaquinvaz commented 3 weeks ago

Any plans to merge this one?

RKakushev commented 3 weeks ago

Have it tested to crash free? Cause it may contains breaking changes on native fbsdk library due changing major version from 16 to 17. @efstathiosntonas

mikehardy commented 3 weeks ago

@RKakushev you can test this and let us know if it's crash free, right? Stated differently: It's open source - if you have a question, do the work and answer it, no one here is working for you, you are working for yourself. Would love to know your results

I'll see about merging

RKakushev commented 3 weeks ago

@RKakushev you can test this and let us know if it's crash free, right? Stated differently: It's open source - if you have a question, do the work and answer it, no one here is working for you, you are working for yourself. Would love to know your results

I'll see about merging

Yes you are right. I just interested about it. Thank you for your work.

mikehardy commented 3 weeks ago

Quick thoughts

No big deal there, this is mostly a note to myself.

mikehardy commented 3 weeks ago

beat my way through all the CI problems and github going down in the interim, great fun. Seems to work locally and CI should work on it now as well after rebasing from the work results and pushing this PR back

Hopefully all goes ✅

efstathiosntonas commented 3 weeks ago

Thank you Mike for your hard work!

Don't know if it's worth mentioning on release notes but it seems like a breaking change to me:

https://github.com/facebook/facebook-ios-sdk/issues/2365#issuecomment-2040534036

mikehardy commented 3 weeks ago

@efstathiosntonas indeed, I'll rebase / reword the commit to include that information, re-push then merge Got some other PRs going through first that are non-breaking first

mikehardy commented 3 weeks ago

cleared the decks in this repo, all PRs merged+released, hopefully the repo goes to sleep for a while again :-)

Cheers

github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 13.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: