thebergamo / react-native-fbsdk-next

MIT License
693 stars 167 forks source link

feat(ios): adopt facebook-ios-sdk 17.1.0 #557

Closed mikehardy closed 2 months ago

mikehardy commented 2 months ago

Investigate the diff between facebook-ios-sdk 17.0.x and 17.1.x, appears fine, and appears to work fine in testing

Note: there is a 17.2.0 apparently already cooking per their changelog but it isn't on cocoapods yet so I couldn't fetch it

I allow the facebook-ios-sdk version to slip for patch versions now but they have a warning about Swift/Obj-C compat on their repo indicating that minor versions may break compiles, so I couldn't let the semver range slip minors. They have broken us before 🤷

Fixes #555

mikehardy commented 2 months ago

Fixed the various deprecation and lint things I saw while examining the CI output Note that one was not fixable as it appears to be an upstream issue, logged here https://github.com/facebook/facebook-ios-sdk/issues/2476