search

thebergamo / react-native-fbsdk-next

MIT License
693 stars 167 forks source link

Info.plist entries in the example app for FacebookAutoLogAppEventsEnabled and FacebookAdvertiserIDCollectionEnabled as Strings instead of Booleans #564

Closed yaroslavnikiforov closed 1 month ago

yaroslavnikiforov commented 1 month ago

🐛 Bug Report

I was reviewing the Info.plist file in the example app and noticed that the following keys are set with string values "FALSE" instead of boolean values:

<key>FacebookAutoLogAppEventsEnabled</key>
<string>FALSE</string>
<key>FacebookAdvertiserIDCollectionEnabled</key>
<string>FALSE</string>

According to Meta's documentation, these keys should be of boolean type: https://developers.facebook.com/docs/app-events/getting-started-app-events-ios#disable-advertiser-id

I'm wondering if this was intentional or if it might be a mistake. Should these values be changed to booleans?

Thank you for your time and assistance!

mikehardy commented 1 month ago

That looks like an error to me - nothing like upstream documentation as a solid basis for argument at least If you proposed a PR to the example and/or to any related documentation that would be a huge help 🙌 well spotted

github-actions[bot] commented 2 weeks ago

:tada: This issue has been resolved in version 13.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: