thebetioplane / osuReplayEditorV3

A replay editor for the rhythm game osu!. Allows you to modify cursor and metadata.
27 stars 5 forks source link

Objects completely not rendering + start time after end time #39

Closed AG89 closed 2 years ago

AG89 commented 2 years ago

https://user-images.githubusercontent.com/22873716/151690682-79551927-f853-465d-ae60-709022a510b7.mp4

Beatmap: https://osu.ppy.sh/beatmapsets/257607#osu/878369

thebetioplane commented 2 years ago

I've found the problem, the beatmap uses decimal numbers in its timing points

[TimingPoints]
997.60640255051,270.00027000027,4,1,0,100,1,0
107917,-90.9090909090909,4,1,0,100,0,0
146797,-100,4,1,0,100,0,0
163807,-86.9565217391304,4,1,0,100,0,0
200797,-76.9230769230769,4,1,0,100,0,0
243997,-66.6666666666667,4,1,0,100,0,0

I referenced the osu!wiki - .osu file format, section timing points - which says these should be integers. Either this beatmap is older than these standards or the beatmapper edited these by hand.

Weird, but if osu! can handle it then I will fix it to allow decimals.

thebetioplane commented 2 years ago

Fixed that issue, but this beatmap seems to have a weird mp3 where when seeking the reporting song time is different from the actual audio time, I'm looking into it

thebetioplane commented 2 years ago

but this beatmap seems to have a weird mp3 where when seeking the reporting song time is different from the actual audio time

Fixed by using BASS_STREAM_PRESCAN when creating audio stream