search

thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

v6 Beta - Action bar transitions #221

Closed iv-gha closed 1 year ago

iv-gha commented 1 year ago

The latest dev version using constraint views is broken

Data:

  1. Song details run under the clock information on small screens.
  2. In performance/stage mode display of Actionbar settings needs to show the clock etc so that the user can see the effect if changes made.
  3. The right menu button is not centred on the Action bar - the settings title should aligned roughly centrally with the icons across the top of the bar - at the moment it is to far down the screen.
  4. Presenter mode does not require the song details information. - transitions in this mode currently flash these details. Updates at the top level in presenter mode need to cleanly display 'Presenter mode'

Due to the complexity of the opensongapp action bar it may be found that constraint views are difficult in use. The song details block and the settings title must align well on the action bar and this appears difficult with constraint views. We may need to revert to the previous design.

thebigg73 commented 1 year ago

The song title doesn't run behind the clock/battery block in constraint layout. The song author did - fixed this

thebigg73 commented 1 year ago

No key set

image
thebigg73 commented 1 year ago

Unfortunately without constraint layout the correct positioning of title, key, capo key and allowing ellipse of the title is virtually impossible - this never worked on v5 as far as I can remember. I'll fix all of the above

thebigg73 commented 1 year ago

Should all be fixed - let me know if not!