search

thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

Enh: Further refinement of toolbar transitions #230

Closed iv-gha closed 1 year ago

iv-gha commented 1 year ago

Hello Gareth,

I hope the last tweaks to toolbar transitions!

See commit comments.

Kind regards Ian

thebigg73 commented 1 year ago

Hi Ian,

I ended up manually updating the files in the last pull request as it kept giving me conflicts that I couldn't solve and a few changes seemed to be reverting back to older code. I think I managed to implement everything you had done with the exception of the over saving of the NonOpenSong.db file - did you see my comments? I added a call more explicitly in the onPause() of MainActivity to save the state. I added in a few extra onResume() calls for the toolbar (name) to the other classes. In case you weren't sure, the prepareStrings() sections are due to the fragment being called with no context (due to lifecycle changes) and since the context was null, trying to use getString() was throwing loads of errors on the Play Store crash log. Pulling them in as strings when context is available (first run) seems to have fixed this.

I'll get a look at your updated PR shortly!

Thanks again Ian for your time and devotion to improving the app! Gareth

On Thu, 4 May 2023 at 15:39, iv-gha @.***> wrote:

Hello Gareth,

I hope the last tweaks to toolbar transitions!

See commit comments.

Kind regards Ian

You can view, comment on, or merge this pull request online at:

https://github.com/thebigg73/OpenSongTablet/pull/230 Commit Summary

File Changes

(9 files https://github.com/thebigg73/OpenSongTablet/pull/230/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/pull/230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52WPBXTCNDLII77ZJNTXEO5SBANCNFSM6AAAAAAXV4TSAA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

iv-gha commented 1 year ago

No problem - sorry for all the work! I fully updated my fork to match yours before this commit so it should behave!