search

thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

Enh: Proposal for change of top spacing of song menu #232

Closed iv-gha closed 1 year ago

iv-gha commented 1 year ago

UI design fun!

iv-gha commented 1 year ago

Hello Gareth,

I had hope that this layout would line up icons? So icons across the top and the settings icon of the main screen - as attached. Does it do this for your devices?

Screenshot_20230514-210236-706~2

thebigg73 commented 1 year ago

Afraid not

On Sun, 14 May 2023 at 21:09, iv-gha @.***> wrote:

Hello Gareth,

I had hope that this layout would line up icons? So icons across the top and the settings icon of the main screen - as attached. Does it do this for your devices?

[image: Screenshot_20230514-210236-706~2] https://user-images.githubusercontent.com/68599243/238207460-b1b17a3d-43f2-4f99-9f3e-b9efced09afb.png

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/pull/232#issuecomment-1546990706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52SZ4WYJ3JE25RIB6E3XGE3XTANCNFSM6AAAAAAX74HG2U . You are receiving this because you modified the open/close state.Message ID: @.***>

iv-gha commented 1 year ago

I fudged the offset for the song menu line up with main menu. The commit has a manual adjust in the margun calc - looks like this needs to be properly calculated - as you understand the margins perhaps you can look at this so that it becomes good on all devices.

Cheers.

On Mon, 15 May 2023, 21:15 Gareth Evans, @.***> wrote:

Afraid not

On Sun, 14 May 2023 at 21:09, iv-gha @.***> wrote:

Hello Gareth,

I had hope that this layout would line up icons? So icons across the top and the settings icon of the main screen - as attached. Does it do this for your devices?

[image: Screenshot_20230514-210236-706~2] < https://user-images.githubusercontent.com/68599243/238207460-b1b17a3d-43f2-4f99-9f3e-b9efced09afb.png

— Reply to this email directly, view it on GitHub < https://github.com/thebigg73/OpenSongTablet/pull/232#issuecomment-1546990706 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB3X52SZ4WYJ3JE25RIB6E3XGE3XTANCNFSM6AAAAAAX74HG2U

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/pull/232#issuecomment-1548514686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQLL3S5BQ333BDQWCSOYJUTXGKFGDANCNFSM6AAAAAAX74HG2U . You are receiving this because you authored the thread.Message ID: @.***>