thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

Chords are not properly aligned when using multiline verses #251

Closed Cryszon closed 9 months ago

Cryszon commented 10 months ago

Using multiline verses makes normal sections' chords misaligned. This is probably because normal sections' chords are padded to accommodate the verse number indicator regardless of whether the section has multiple verses or not.

Here are two screenshots that illustrate the problem: Screenshot_20231124_160421_OpenSongApp

Screenshot_20231124_160441_OpenSongApp

thebigg73 commented 10 months ago

You are exactly right with the reason behind that bug. I've added a fix for the next release that checks for wrongly formatted 'non-multiline' sections. [image: image.png]

Thanks for alerting me to the bug!

Gareth

On Fri, 24 Nov 2023 at 14:11, Kimmo Salmela @.***> wrote:

Using multiline verses makes normal sections' chords misaligned. This is probably because normal sections' chords are padded to accommodate the verse number indicator regardless of whether the section has multiple verses or not.

Here are two screenshots that illustrate the problem: [image: Screenshot_20231124_160421_OpenSongApp] https://user-images.githubusercontent.com/5220970/285477443-fbec7769-2362-4e82-8880-02722b7874e7.jpg

[image: Screenshot_20231124_160441_OpenSongApp] https://user-images.githubusercontent.com/5220970/285477501-23472d9a-b7a6-49ac-b940-79a7bd6c333f.jpg

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52QB4OHRACZNA5HECVLYGCTHRAVCNFSM6AAAAAA7ZF7GGSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDSNZZGE2DKNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>