search

thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

v6 Set tab - functional problem #259

Open iv-gha opened 7 months ago

iv-gha commented 7 months ago

Hello Gareth,

The set highlights / list scroll are being considered for local loads but not for received songs. Perhaps a need to ensure Set tab and Song tab updated are called as part of song load.

Cheers Ian

iv-gha commented 5 months ago

?

thebigg73 commented 5 months ago

I'm assuming this is because received songs have a different file location to the song menu and set menu items. Both have a folder/filename identification, whereas received songs are temporarily stored in ../Received/filename, so can't (and probably shouldn't) be identified as the same item. Have I understood correctly?

iv-gha commented 5 months ago

If it is in the list, highlight and scroll. If not, clear highlight, scroll to top. A received song is not in the list, so 'if not' action applies. This is one of the 'on song load' activities.

iv-gha commented 5 months ago

?

thebigg73 commented 5 months ago

Should be addressed in updates. Set menu is scrolled to position when song is loaded (in the do after settle section). If not found, the set scrolls to the top - I might change this part, as sometimes it is better to keep the current last used set position. This would allow a user to deviate from a set, but quickly resume from their planned order?

iv-gha commented 5 months ago

I think highlight means the current song - it is confusing that it may mean something else.

thebigg73 commented 5 months ago

Correct. Highlight is the current song. So if not in a set, no song is highlighted in the set. I just meant not to scroll to the top if the song being viewed is not in the set, just unhighlight any previously selected/highlighted item

On Sun, 16 Jun 2024, 21:32 iv-gha, @.***> wrote:

I think highlight means the current song - it is confusing that it may mean something else.

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/259#issuecomment-2171869372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52TLGWQCJQLOF5XZ3XDZHXY47AVCNFSM6AAAAABFZO4WHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRHA3DSMZXGI . You are receiving this because you commented.Message ID: @.***>