thebigg73 / OpenSongTablet

Android port of OpenSong. Use your mobile device as a portable song book. Gareth Evans
GNU General Public License v3.0
32 stars 23 forks source link

Comments after chords - how it displays #264

Open iv-gha opened 4 months ago

iv-gha commented 4 months ago

Where multiple endings of a section - so different chords for entry to chorus, to bridge, ending etc - the second, third.etc. versions lyric lines are set as comments.

It is an OpenSongApp deliberate quirk that supports multi version of a line.

Saw the forum post suggesting it as a bug

Currently a comment after chord line is deliberately coded to display as lyric for chords over lyric views, as comment for lyrics only views and not to project.

FYI.

iv-gha commented 4 months ago

Will recent changes break this? If so, how do users suppress project of genuine lyric lines - without breaking compatibility with OpenSong format? So only 1 of multiple line versions - to get 1 to project only.

thebigg73 commented 3 months ago

Comment lines should always display as comment lines, otherwise they should be lyric lines. This is how OpenSong displays image

iv-gha commented 3 months ago

Understood.

So how do we stop a lyric line projecting please. The case of multiple versions of the same line, all with the same lyric? This is the case where a v5 quirk, coded to bein v6 ('til now) supported use of ; - it gave no project (but did not edit well).

So, a facility to have a lyric line that does not project - ta.

thebigg73 commented 3 months ago

That's where curly brackets comes in. This is for OpenSongApp only, OpenSong ignores it. https://www.opensongapp.com/user-manual/display/song-display#h.23x5lw4amf8t

On Sun, 9 Jun 2024 at 10:09, iv-gha @.***> wrote:

Understood.

So how do we stop a lyric line projecting please. The case of multiple versions of the same line, all with the same lyric? This is the case where a v5 quirk, coded to bein v6 ('til now) supported use of ; - it gave no project (but did not edit well).

So, a facility to have a lyric line that does not project - ta.

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/264#issuecomment-2156404288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52X3DYSQVNTBHRTNDC3ZGQLS7AVCNFSM6AAAAABIPXXE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGQYDIMRYHA . You are receiving this because you commented.Message ID: @.***>

thebigg73 commented 3 months ago

The comment line will still not project, so that function still exists. It will still display in Performance mode though, but will now be highlighted/formatted as a comment line rather than a lyrics line. That's what the last change does.

On Sun, 9 Jun 2024 at 11:53, Gareth Evans @.***> wrote:

That's where curly brackets comes in. This is for OpenSongApp only, OpenSong ignores it. https://www.opensongapp.com/user-manual/display/song-display#h.23x5lw4amf8t

On Sun, 9 Jun 2024 at 10:09, iv-gha @.***> wrote:

Understood.

So how do we stop a lyric line projecting please. The case of multiple versions of the same line, all with the same lyric? This is the case where a v5 quirk, coded to bein v6 ('til now) supported use of ; - it gave no project (but did not edit well).

So, a facility to have a lyric line that does not project - ta.

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/264#issuecomment-2156404288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52X3DYSQVNTBHRTNDC3ZGQLS7AVCNFSM6AAAAABIPXXE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGQYDIMRYHA . You are receiving this because you commented.Message ID: @.***>

thebigg73 commented 3 months ago

[image: comment line.png]

Note the comment lines (starting with ;) showing Identical lines at the top. Does not display.

On Sun, 9 Jun 2024 at 11:55, Gareth Evans @.***> wrote:

The comment line will still not project, so that function still exists. It will still display in Performance mode though, but will now be highlighted/formatted as a comment line rather than a lyrics line. That's what the last change does.

On Sun, 9 Jun 2024 at 11:53, Gareth Evans @.***> wrote:

That's where curly brackets comes in. This is for OpenSongApp only, OpenSong ignores it.

https://www.opensongapp.com/user-manual/display/song-display#h.23x5lw4amf8t

On Sun, 9 Jun 2024 at 10:09, iv-gha @.***> wrote:

Understood.

So how do we stop a lyric line projecting please. The case of multiple versions of the same line, all with the same lyric? This is the case where a v5 quirk, coded to bein v6 ('til now) supported use of ; - it gave no project (but did not edit well).

So, a facility to have a lyric line that does not project - ta.

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/264#issuecomment-2156404288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52X3DYSQVNTBHRTNDC3ZGQLS7AVCNFSM6AAAAABIPXXE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGQYDIMRYHA . You are receiving this because you commented.Message ID: @.***>

iv-gha commented 3 months ago

Sorry, you are not quite getting it. For variants of a single line, all chords over lyric lines, all want correct display as chord over lyric. Only the first to project.

;(1. To VERSE)
.         Gm7              Csus  C           F   Gm7  Bb
 For Your power at work in me    is changing me
;(2. To END)
.         Gm7              Csus  C           F   Gm7  Bb  F
 For Your power at work in me    is changing me

SongSelect can have line varants.

So, how to stop the second variant projecting.

iv-gha commented 3 months ago

Added example for prev comment. This is v5 - v6.14 file using the comment lyric 'quirk' to suppress projection. Only 1 line projects.

How to do now?

Screenshot_20240609-183622~2 Screenshot_20240609-183642~2

iv-gha commented 3 months ago

?

thebigg73 commented 3 months ago

screenshot screenshot2

iv-gha commented 3 months ago

Note in my example all three lines are aligned as chords over lyrics. My comment size is much smaller making this more obvious.

Your performance screenshot does not seem to get the first line alignment right and uses comment font for lyrics of line 2 and 3? So not 3 chords over lyric lines?

thebigg73 commented 3 months ago

It did align before I tried to revert it! I'll fix it shortly. Comment lines should display as comment lines, so will resize as appropriate (based on your scaling choice). I'll get the chord- comment alignment working again. I'm super busy at work and band gigs just now (my first day and evening to myself in over 3 weeks).

On Sun, 16 Jun 2024, 21:48 iv-gha, @.***> wrote:

Note in my example all three lines are aligned as chords over lyrics. My comment size is much smaller making this more obvious.

Your performance screenshot does not seem to get the first line alignment right and uses comment font for lyrics of line 2 and 3? So not 3 chords over lyric lines?

— Reply to this email directly, view it on GitHub https://github.com/thebigg73/OpenSongTablet/issues/264#issuecomment-2171873276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3X52XH3Z3XKQWFPKUZAA3ZHX2ZVAVCNFSM6AAAAABIPXXE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRHA3TGMRXGY . You are receiving this because you commented.Message ID: @.***>