search

thebigpotatoe / Super-Simple-RGB-WiFi-Lamp

A project based on the ESP8266 and WS2812b
MIT License
66 stars 28 forks source link

Local improvements #33

Open jennytoo opened 4 years ago

jennytoo commented 4 years ago

Various changes to support vscode or fix a few issues I had.

I'm sorry about the reformatting; I'm new to vscode and not sure where to configure it. I dislike braces being on new lines by themselves, but do like consistency.

jennytoo commented 4 years ago

Looks like Lars also implemented a different fix to both the currentMode and led flicker issues.

The Name and VSCode changes are still useful and I can rebase this without the two bug fixes instead.

I'm not sure if his change for the flicker is sufficient though - I tried a similar approach and while reduced I still had flickering. For me it was sufficient to do a loop between the render and draw code to give the rest of the code a chance to process other events. I'm running two ESP8266s, one with 100 LEDs and one with ~80 LEDs (but set to 100 in the build still). Both exhibited this issue.

thebigpotatoe commented 4 years ago

https://github.com/thebigpotatoe/Super-Simple-RGB-WiFi-Lamp/pull/33/commits/3605f1df9f199fe6480ff186188227da9be1a08c - I like the idea of adding platform IO. I have no experience in it though, so are all the files committed required or do you just need the config file?

https://github.com/thebigpotatoe/Super-Simple-RGB-WiFi-Lamp/pull/33/commits/ed08f37d49b6ee2c429e13eb63d14eefc01d379c - I believe this has been fixed? I have lost the commit to where it is however. I'll have to double check.

https://github.com/thebigpotatoe/Super-Simple-RGB-WiFi-Lamp/pull/33/commits/1cac87cb355dbf363868e09ce7360a5c47c41360 - There are now several pulls to fix this issue, I think they needs to be tested and consolidated first. They also need to be tested with the latest Arduino version too if you have not already?