search

thebitguru / play-button-itunes-patch

Play Button iTunes Patch
http://www.thebitguru.com/projects/iTunesPatch
Other
644 stars 19 forks source link

Mac OS Sierra not working #33

Closed spydercapriani closed 7 years ago

spydercapriani commented 7 years ago

Doesn't appear to be functioning in Mac OS Sierra.

Have disabled csrutil, installed dmg, tested and found that it still launches iTunes when iTunes is not running.

com.thebitguru.Play-Button-iTunes-Patch 2016-09-19 16-42.log.txt

thebitguru commented 7 years ago

Interesting. Everything in the log seems as I would expect it to be. Can you confirm that you have tried after restarting?

spydercapriani commented 7 years ago

I restarted after installation and once more just now just to be sure. Still appears to be launching iTunes when issuing the play/pause command.

thebitguru commented 7 years ago

I am not sure what else to try. This used to work in El Capitan, right? Which mac are you using?

spydercapriani commented 7 years ago

I must admit that I did not actually attempt to use this in El Capitan. I am using a Mac Pro. Do you know of a way to emulate the media key via an AppleScript? I just wonder if it is not the keyboard software that is purposefully sending a script for iTunes Play/Pause. However, my whole intention for installing this was to work in conjunction with my bluetooth headphones and so I am also using https://github.com/jguice/mac-bt-headset-fix

On Mon, Sep 19, 2016 at 8:26 PM, Farhan Ahmad notifications@github.com wrote:

I am not sure what else to try. This used to work in El Capitan, right? Which mac are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thebitguru/play-button-itunes-patch/issues/33#issuecomment-248176377, or mute the thread https://github.com/notifications/unsubscribe-auth/AHXkNn8O0t5EajoyH9Q_yYcKtKR6Y3YKks5qrzY5gaJpZM4KAtVd .

Sincerely,

Danny Gilbert

thebitguru commented 7 years ago

Oh, it's bluetooth headphones! Yes, this patch is not expected to fix that because many times that functionality is implemented by proprietary drivers that the manufacturer provides. Which headphones do you use, and did you have to install anything special for it to work?

I should really buy some myself and see if there is a different binary that needs to be patched.

spydercapriani commented 7 years ago

I have been trying to get my bluetooth headphones to work with Spotify and came across this post in some forums https://community.spotify.com/t5/Desktop-Linux-Windows-Web-Player/Bluetooth-headset-buttons/td-p/161796 that pointed out your solution combined with the mac-bt-headset-fix would do the trick.

I am currently using a pair of Trek Titanium bluetooth headphones. They didn’t come with any special software (that I’m aware of).

What lead me to submit the issue though was that my keyboard media keys were also attempting to launch iTunes after installing this iTunes patch. I am using the Microsoft Ergonomic 4000 keyboard which comes with Microsoft IntelliType Pro software which allows you to reprogram some of the special keys.

On Tue, Sep 20, 2016 at 10:40 AM, Farhan Ahmad notifications@github.com wrote:

Oh, it's bluetooth headphones! Yes, this patch is not expected to fix that because many times that functionality is implemented by proprietary drivers that the manufacturer provides. Which headphones do you use, and did you have to install anything special for it to work?

I should really buy some myself and see if there is a different binary that needs to be patched.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thebitguru/play-button-itunes-patch/issues/33#issuecomment-248340593, or mute the thread https://github.com/notifications/unsubscribe-auth/AHXkNsk7Rt_GsZjyHw9Ur7wq8pIp9Tlaks5qr_5VgaJpZM4KAtVd .

Sincerely,

Danny Gilbert

thebitguru commented 7 years ago

I see. The intent of this patch is to just prevent the base operating system from launching iTunes. Beyond that, as you are finding out, there are additional pieces that make this complicated and unreliable.

The keyboard should still work as expected, but I am guessing that it is likely the Microsoft software that's overriding the functionality. What is that configured to do when the play/pause button is pressed?

sdebruyn commented 7 years ago

In El Capitan pressing Play/Pause on my BT headphones worked as expected. It never opened iTunes and just paused my Spotify. In Sierra, it opens iTunes and Spotify continues to play. Would this patch fix that?

thebitguru commented 7 years ago

Unfortunately, no, this patch does not address BT headphones. You might want to try https://github.com/jguice/mac-bt-headset-fix

iiNku commented 7 years ago

I see that you have closed the issue but I'm still facing it :(

thebitguru commented 7 years ago

@iiNku, can you explain what specifically you are facing?