search

thebitguru / play-button-itunes-patch

Play Button iTunes Patch
http://www.thebitguru.com/projects/iTunesPatch
Other
644 stars 19 forks source link

Not functioning on High Sierra (10.13.1) #43

Open dmlemos opened 6 years ago

dmlemos commented 6 years ago

Recently upgraded to 10.13.1, and after disabling SIP and patched iTunes is still opening. It was working before with Sierra up until now.

Attached is the log com.thebitguru.Play-Button-iTunes-Patch 2017-12-02 17-32.log

thebitguru commented 6 years ago

Hi, @dmlemos,

Thanks for reporting this and sharing the log file. Based on the log, the file should already be patched. Can you confirm that you restarted your Mac after patching? Also, by any chance, are you trying the play/pause button on a Bluetooth headset?

dmlemos commented 6 years ago

I tried to patch it twice. And yes I restarted the mac. Just using the internal keyboard nothing more.

thebitguru commented 6 years ago

That's really weird. The log says that the file is patched. Can you attach the output of the following command?

strings /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd

peterguy commented 6 years ago

Doesn't work for me on High Sierra as well. The patch GUI said that the rdc status was "Patched." when I first ran it, even though I had not run it before. I ran the patching anyway, it prompted for my password several times, and proclaimed that it was patched and now there was a backup.

Here are some comparisons of the patched file and the backup: 

Johnny-Five:~ peter$ ls -l /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd*
-rwxr-xr-x  1 root  wheel  40656 Dec  5 18:20 /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd
-rwxr-xr-x  1 root  wheel  41296 Dec  5 18:20 /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd_backup_1.1_20171205_18_20.22

Johnny-Five:~ peter$ cksum /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd*
794668000 40656 /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd
2939926531 41296 /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd_backup_1.1_20171205_18_20.22

Johnny-Five:~ peter$ strings /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd > rdc.strings
Johnny-Five:~ peter$ strings /System/Library/CoreServices/rcd.app/Contents/MacOS/rcd_backup_1.1_20171205_18_20.22 > rcdbak.strings
Johnny-Five:~ peter$ diff rdc.strings rcdbak.strings 
Johnny-Five:~ peter$

No difference in the strings output between the patched one and the backup.

I've attached the strings output from the patched one, since there was no difference, the log file, and a screenshot of the GUI after patching.

com.thebitguru.Play-Button-iTunes-Patch 2017-12-06 02-19.log

rdc.strings.txt

screen shot 2017-12-05 at 6 46 23 pm

peterguy commented 6 years ago

Looks like _FIND_COMMAND_DATA is no longer in the executable. Wonder if that has been moved off somewhere else.

thebitguru commented 6 years ago

Sorry, I have been quite consumed by my primary job. I will look into this as soon as I can.

peterguy commented 6 years ago

No apology needed - be glad you have a primary job! :-)

I saw your clever hack in Patcher.m, and I did some digging through the strings of various other executables involved in the launching of iTunes, like mediaremoted, but I did not find any obvious candidate for the same kind of command substitution.

macOS Sierra really messed up the RCD hacking crowd - there is a liberal sprinkling of "doesn't work in macOS Sierra!" issues, like this one, so you are not alone. I have a feeling a completely different approach will be needed.

pickanothername commented 6 years ago

+1 for this. Had the same exact experience, and I'm at my wit's end.

thebitguru commented 6 years ago

@peterguy :) Thanks for sharing the details! I finally got a chance to start looking more into this. I agree with your assessment that Apple has changed how they are launching iTunes in 10.13, I didn't find any references to the string that the patch was replacing before.

Sounds like this will require some serious detective work again.

I have noticed that in High Sierra I haven't needed this. I did switch to a different media player (Swinsian) which could be the reason. Can one of you please let me know the name of the media player that you are using where this is an issue?

peterguy commented 6 years ago

No alternate media player here: I was actually hoping to use your patch to stop iTunes from launching every time I connected to a bluetooth speaker.

On Jan 12, 2018, at 7:27 PM, Farhan Ahmad notifications@github.com wrote:

@peterguy https://github.com/peterguy :) Thanks for sharing the details! I finally got a chance to start looking more into this. I agree with your assessment that Apple has changed how they are launching iTunes in 10.13, I didn't find any references to the string that the patch was replacing before.

Sounds like this will require some serious detective work again.

I have noticed that in High Sierra I haven't needed this. I did switch to a different media player (Swinsian) which could be the reason. Can one of you please let me know the name of the media player that you are using where this is an issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thebitguru/play-button-itunes-patch/issues/43#issuecomment-357406247, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH5AB7NWmrsmtb8hcvig0kgVCMyAmXsks5tKCKegaJpZM4QzZZ-.

dmlemos commented 6 years ago

I use cmus and sometimes spotify.

Mebius973 commented 6 years ago

Hi guys, to bad this is not working anymore :-( I don't know if that could help you but this project does some jam with the media keys, maybe it's approach could be reusable https://github.com/milgra/highsierramediakeyenabler