Closed harshkhandeparkar closed 5 years ago
@sahil-patel6 grunt done. Please review :) (from github site)
Ohh excellent!!
On Thu, 4 Apr, 2019, 21:39 Harsh Khandeparkar, notifications@github.com wrote:
@sahil-patel6 https://github.com/sahil-patel6 grunt done. Please review :) (from github site)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HarshKhandeparkar/smart-car-parking/pull/17#issuecomment-479962188, or mute the thread https://github.com/notifications/unsubscribe-auth/AROeQVirQNrGAA7xG6Etyg7WDBALt7jSks5vdiOqgaJpZM4cdLcs .
Please review the code changes also.
Please check if there are any code/syntax errors etc. @sahil-patel6
You will get to know what I have done even if you don't know anything about grunt. Or atleast ask me questions about it so you understand the basics. Finally, both of us should be aware of the changes in code. Finally, we are in a team.
Ok I will check it out
On Thu, 4 Apr, 2019, 22:16 Harsh Khandeparkar, notifications@github.com wrote:
You will get to know what I have done even if you don't know anything about grunt. Or atleast ask me questions about it so you understand the basics. Finally, both of us should be aware of the changes in code. Finally, we are in a team.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HarshKhandeparkar/smart-car-parking/pull/17#issuecomment-479975850, or mute the thread https://github.com/notifications/unsubscribe-auth/AROeQd3vZ_OKU04wNPfsj3HpxMRIMai0ks5vdix2gaJpZM4cdLcs .
Shall I merge this? @sahil-patel6
As you wish
On Fri, 5 Apr, 2019, 13:51 Harsh Khandeparkar, notifications@github.com wrote:
Shall I merge this? @sahil-patel6 https://github.com/sahil-patel6
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HarshKhandeparkar/smart-car-parking/pull/17#issuecomment-480190513, or mute the thread https://github.com/notifications/unsubscribe-auth/AROeQUqv0aP246GM4pDo20PfMJFSVZ4aks5vdweHgaJpZM4cdLcs .
Ok. Merging....
Fixes #7