thebookisclosed / ViVe

C# library and console app for using new feature control APIs available in Windows 10 version 2004 and newer
GNU General Public License v3.0
4.89k stars 298 forks source link

[Feature dictionary update] Add various missing features from mach2 repo #120

Closed Pinguin2001 closed 3 months ago

Pinguin2001 commented 10 months ago

This PR adds 86 missing features to FeatureDictionary, all of which are present in 25997

thebookisclosed commented 10 months ago

The IDs aren't ordered in their usual fashion, it should be from highest to lowest globally, plus the few high ID outliers stuck at the bottom. I'm also quite certain that more than 86 features had to have popped up since the last dictionary update 6 months ago and I don't want to push a partial update.

Pinguin2001 commented 10 months ago

Okay, yes, there are more which have been added. I will create a new feature dictionary with all IDs from all builds and sort them accordingly

Pinguin2001 commented 10 months ago

This feature dictionary should contain all IDs from the mach2 feature repo up until Build 25997 In addition I sorted the IDs accordingly I hope this helps!

Pinguin2001 commented 10 months ago
image

image

Since the dictionary hasn't been updated in a really long time, features have been renamed, thus causing duplication problems. What should I do with them?

thebookisclosed commented 10 months ago

Unfortunately the latest commit is still problematic, features like USB4SettingsDomainsViewer occur multiple times with different IDs Maintaining the list is not a fun task, if you are fine with waiting a few days more I'll make the final adjustments myself.

Pinguin2001 commented 10 months ago

That would be great. These features toggle the same underlying functionality, but their IDs differ in different builds. In the future ill keep an eye on added features in the mach2 repo and once I have time, Ill add them to the dictionary. Updating an old list is much more time consuming than adding a few new features every build

thebookisclosed commented 3 months ago

I finally powered through all the changes and a huge update/commit is now live (fef901f)

Pinguin2001 commented 3 months ago

Great, thanks for your efforts! Finally the lists are up-to-date again