thebookisclosed / ViVe

C# library and console app for using new feature control APIs available in Windows 10 version 2004 and newer
GNU General Public License v3.0
4.89k stars 298 forks source link

Deactivated tabs appear on their own on the second restart #56

Closed Dhyfer1 closed 1 year ago

Dhyfer1 commented 2 years ago

Hi.

I am using the latest version of ViveTool on Windows 11 Beta channel (version 22H2 Compilation 22622.575)

The content of the unzipped Vivetool folder is located at C:\Users\UserName\Downloads\ViveTool

I want to disable the file explorer tabs permanently, so that after every reboot or a shutdown/startup of my PC, the file explorer appears without tabs. So I have used ViveTool (added to the system environment variables) in the command console running as Administrator, so to disable the tabs permanently I have used this code:

vivetool /disable /id:37634385 /store:both 37634385 is the ID to activate the tabs in the beta channel

After entering those parameters vivetool says "Successfully set feature configuration", so I restart my PC to apply the changes, and when I open the file explorer I can see that it has no more tabs, but after a second restart the tabs automatically reappear.

Is there any missing parameter in the code I mentioned to disable the tabs permanently or what else can I do about it?

Thanks in advance

thebookisclosed commented 2 years ago

Please query the ID right after you disable it and then once it gets re-enabled & paste the outputs here.

Dhyfer1 commented 2 years ago

Ok. This is the report:

  1. With tabs enabled in the file explorer, I check the query for the specific ID with the command: vivetool /query /id:37634385 and the result is:
    [37634385]
    Priority        : Service (4)
    State           : Enabled (2)
    Type            : Override (0)
    HasSubscriptions: True
  2. Then I run the command vivetool /disable /id:37634385 /store:both to deactivate the tabs and then restart the PC
  3. After rebooting, the explorer has no tabs. So I check the query again and it gives as a result:
    [37634385]
    Priority        : Service (4)
    State           : Disabled (1)
    Type            : Override (0)
    HasSubscriptions: True
  4. Then, I restart my PC for the second time and when I log in I open the file explorer and I see that the tabs reappeared by on their own. Then I check the query again and the result is the same as before disabling the tabs.
    [37634385]
    Priority        : Service (4)
    State           : Enabled (2)
    Type            : Override (0)
    HasSubscriptions: True

    I don't know what the problem is, I am waiting for your help. Thanks in advance

nobodysclown commented 1 year ago

Same here

thebookisclosed commented 1 year ago

Same here

What build are you running? What channel are you enrolled in?

Dhyfer1 commented 1 year ago

@thebookisclosed I still have the same problem, is that there is no definitive solution?

ivanez82 commented 1 year ago

The same problem here..

thebookisclosed commented 1 year ago

@Dhyfer1 Are you still able to consistently reproduce the issue? If so, can you please check if disabling the \Microsoft\Windows\Flighting\FeatureConfig\ReconcileFeatures task makes the unwanted revert on second restart stop happening? Even if it does, please don't keep the task disabled -- it's just a way for me to narrow down the problem & serves as a workaround for the time being.

Dhyfer1 commented 1 year ago

@Dhyfer1 Are you still able to consistently reproduce the issue? If so, can you please check if disabling the \Microsoft\Windows\Flighting\FeatureConfig\ReconcileFeatures task makes the unwanted revert on second restart stop happening? Even if it does, please don't keep the task disabled -- it's just a way for me to narrow down the problem & serves as a workaround for the time being.

Hi. When after a reboot the tabs appeared, I ran vivetool again with the command that I mentioned in my first message vivetool /disable /id:37634385 /store:both, but before rebooting I opened the task scheduler and did what you said in https://github.com/thebookisclosed/ViVe/issues/6#issuecomment-670479651 so I deactivated ReconcileFeatures and then restarted my PC.

After turning turn on/restarting my PC several times, the tabs haven't reappeared, but I have noticed that if I turn ReconcileFeatures back on, the tabs reappear, so for now I always have ReconcileFeatures disabled.

Your workaround has been helpful, but are there any consequences for having ReconcileFeatures always disabled?

thebookisclosed commented 1 year ago

@Dhyfer1 Would you mind sending over your FeatureConfig*.json files from C:\ProgramData\Microsoft\Windows\OneSettings?

Dhyfer1 commented 1 year ago

@thebookisclosed Of course, here is the file:

FeatureConfig.zip FeatureConfig.bak.json.zip

I look forward to hearing from you. Thanks in advance

thebookisclosed commented 1 year ago

When the task is enabled, do the tabs consistently come back within 2 reboots even if you do them in quick succession or is some waiting required? Having a hard time reproducing this, still

Only thing that would make sense to me is for this to either stop reverting (temporarily) or your PC is being served new feature batches at an uncommonly fast rate. If you can consistently reproduce the reverts please check the timestamp of FeatureConfig.json and tell me if it's dated after you've performed the /disable command.

One more small thing, there is no need to explicitly specify /store:both because that is the default behavior.

thebookisclosed commented 1 year ago

v0.3.2 is now out with a /fixpriority command which should fix issues like this one, please try it and let me know if any of the unintended behavior persists. It's designed for one time use on devices where you've used v0.3.0 or v0.3.1 in the past, just like the changelog says. (These versions are unfortunately capable of creating overrides that won't stick perfectly and potentially pause remote feature delivery to your system, unintentionally.)

ivanez82 commented 1 year ago

Apparently in my case the problem has been solved with v0.3.2 and the /fixpriority command, I restarted several times and it has not returned

ivanez82 commented 1 year ago

now with the KB5019509 update i dont get activated the explorer tabs and the other new features.... what i have to do?

ivanez82 commented 1 year ago

Well I fix IDs custom configuration with the /reset commnad.. I hope this is the right way..

thebookisclosed commented 1 year ago

If you've had a Disable override configured before and wanted them to show up now then yes, a Reset is the correct way to remove the old override.

Dhyfer1 commented 1 year ago

When the task is enabled, do the tabs consistently come back within 2 reboots even if you do them in quick succession or is some waiting required? Having a hard time reproducing this, still

When the task is activated, sometimes after the first reboot (sometimes after two reboots in a row without waiting time) the tabs reappear just by opening the file explorer once, this is how it worked with the previous version of vivetool 0.3.1.

Only thing that would make sense to me is for this to either stop reverting (temporarily) or your PC is being served new feature batches at an uncommonly fast rate. If you can consistently reproduce the reverts please check the timestamp of FeatureConfig.json and tell me if it's dated after you've performed the /disable command.

You still need to know this? the latest version of vivetool was able to fix the problem, I even re-enabled ReconcileFeatures in the task scheduler and the tabs no longer appear.

One more small thing, there is no need to explicitly specify /store:both because that is the default behavior.

Hmm. Several months ago, when I used the command vivetool /disable /id:37634385 for the first time without /store:both, on the second reboot the tabs reappeared, so I had to add /store:both, to save the configuration permanently and not disappear after a reboot, and I was guided by what it says here.

Also vivetool says it so when I type vivetool /enable /? in cmd: Writing to the Boot store is necessary for features to persist across reboots. Changes to this store become effective the next time you reboot. The Runtime store can be used to make instantenous changes, however not all features support this, meaning a reboot may be required to apply changes. Use both for best results.

By the way, I still don't understand how to use the new /fixpriority command. With the file explorer without tabs, a couple of days ago I just opened cmd as administrator (before this I had re-enabled the ReconcileFeatures task) and typed vivetool /fixpriority, then I restarted my PC and the explorer was still without tabs, in fact it is still without tabs. But my question is, in a new Windows installation, how do I use this new command to disable tabs permanently? I mean, do I write it like this vivetool /disable /id:37634385 /store:both /fixpriority or vivetool /disable /id:37634385 /fixpriority or just use vivetool /fixpriority after removing the tabs?

novincobra commented 1 year ago

Well I fix IDs custom configuration with the /reset commnad.. I hope this is the right way..

I try /fullreset working perfect, after i have problem with update to new windows update oct 2022 not showing tab of new windows feature

thebookisclosed commented 1 year ago

When the task is activated, sometimes after the first reboot (sometimes after two reboots in a row without waiting time) the tabs reappear just by opening the file explorer once, this is how it worked with the previous version of vivetool 0.3.1.

As long as it's inconsistent like that the uncommonly fast feature push rate theory makes the most sense.

Hmm. Several months ago, when I used the command vivetool /disable /id:37634385 for the first time without /store:both, on the second reboot the tabs reappeared, so I had to add /store:both, to save the configuration permanently and not disappear after a reboot, and I was guided by what it says here.

Also vivetool says it so when I type vivetool /enable /? in cmd: Writing to the Boot store is necessary for features to persist across reboots. Changes to this store become effective the next time you reboot. The Runtime store can be used to make instantenous changes, however not all features support this, meaning a reboot may be required to apply changes. Use both for best results.

Do not rely on tutorials for teaching you good syntax. Additionally what you've cited is simply an explanation of what the stores are for, within that same help text you can also find this. The parameters in square brackets don't need to be specified and will use these defaults: Store : Both

By the way, I still don't understand how to use the new /fixpriority command. With the file explorer without tabs, a couple of days ago I just opened cmd as administrator (before this I had re-enabled the ReconcileFeatures task) and typed vivetool /fixpriority, then I restarted my PC and the explorer was still without tabs, in fact it is still without tabs. But my question is, in a new Windows installation, how do I use this new command to disable tabs permanently? I mean, do I write it like this vivetool /disable /id:37634385 /store:both /fixpriority or vivetool /disable /id:37634385 /fixpriority or just use vivetool /fixpriority after removing the tabs?

/fixpriority is a top-level command, not an argument to use enabling or disabling features. It's designed for one time use on devices where you've used v0.3.0 or v0.3.1 in the past, just like the changelog says. These versions are unfortunately capable of creating overrides that won't stick perfectly and potentially pause remote feature delivery to your system, unintentionally. Running it on a new install would simply make it say No configurations in this store need to be moved as there is nothing to fix. v0.3.2 and newer create better ("fixed," in this context) overrides by default.

You can double check this by taking a peek at the global /? which describes /fixpriority as Moves Override type configurations from Service to User priority, while /enable /? now says that the Priority default is User, as opposed to Service in earlier versions.

Dhyfer1 commented 1 year ago

Do not rely on tutorials for teaching you good syntax. Additionally what you've cited is simply an explanation of what the stores are for, within that same help text you can also find this. The parameters in square brackets don't need to be specified and will use these defaults: Store : Both

Ok. I got it, so the command will use /store:both even if it is not typed in, did I understand correctly?

/fixpriority is a top-level command, not an argument to use enabling or disabling features. It's designed for one time use on devices where you've used v0.3.0 or v0.3.1 in the past, just like the changelog says. These versions are unfortunately capable of creating overrides that won't stick perfectly and potentially pause remote feature delivery to your system, unintentionally. Running it on a new install would simply make it say No configurations in this store need to be moved as there is nothing to fix. v0.3.2 and newer create better ("fixed," in this context) overrides by default.

Wait, let me see if I understand. So, in a new Windows installation, I have to use the previous version of vivetool 0.3.1 with the command vivetool /disable /id:37634385 to disable the tabs and then use vivetool 0.3.2 with the command vivetool /fixpriority?

Because if I use the latest version 0.3.2 to disable the tabs and then run vivetool /fixpriority it doesn't work?

thebookisclosed commented 1 year ago

Ok. I got it, so the command will use /store:both even if it is not typed in, did I understand correctly?

Yes.

Wait, let me see if I understand. So, in a new Windows installation, I have to use the previous version of vivetool 0.3.1 with the command vivetool /disable /id:37634385 to disable the tabs and then use vivetool 0.3.2 with the command vivetool /fixpriority?

Because if I use the latest version 0.3.2 to disable the tabs and then run vivetool /fixpriority it doesn't work?

No! It would be incredibly inconvenient if I released a version that requires you to use another version to achieve what you want. Like I said, v0.3.2 and newer create better ("fixed," in this context) overrides by default. Creating a new feature override in v0.3.0/1 and then running /fixpriority in v0.3.2 achieves the same end result as creating a feature override in v0.3.2. /fixpriority is something you should turn to ONLY if the device has configurations created by v0.3.0/1, its purpose is to fix bad existing configurations, there should not be a need to run it multiple times. If you enabled the same feature in v0.3.0/1 and then in v0.3.2 without running /fixpriority in the meantime, both the bad and the good configuration would coexist, potentially causing problems.

Dhyfer1 commented 1 year ago

Ah, ok. I think I'm getting the idea. So this new /fixpriority command should only be used to fix configurations executed with the previous versions of vivetool (0.3.0 and 0.3.1), so I have no need to use /fixpriority if I am ONLY going to use the latest version to disable tabs in a clean Windows installation.

So, if I understand correctly, if I only plan to use the latest version 0.3.2 to disable the tabs, I just have to run the command vivetool /disable /id:37634385 and that's it (I won't have to disable the ReconcileFeatures task and I won't have to use /fixpriority).

Did I get it right this time? apologies to this newbie 😅

thebookisclosed commented 1 year ago

Yes, that is correct. 😊 I have updated the wording about /fixpriority in v0.3.2's changelog to hopefully reduce any future confusion.

Dhyfer1 commented 1 year ago

Ok. Thank you for your patience. I am currently reinstalling Windows, so when I use the latest version of vivetool I will let you know (some hours later) if the disabled tabs no longer reappear after more than two system reboots.

Dhyfer1 commented 1 year ago

Hi. The latest version works very well! After reinstalling Windows, and after using the latest version of vivetool with the command vivetool /disable /id:37634385 the tabs have disappeared forever, even after more than two reboots (up to 7 reboots in a row I have done) the tabs haven't appeared anymore. I didn't need to disable the ReconcileFeatures task and didn't use /fixpriority. So this issue can be closed now.

Thank you! 😊

thebookisclosed commented 1 year ago

Thank you for the update, closing the issue then 😊