Currently, that provider's actions always run, instead of:
load current resource
see if it needs updating
only run action if needed
If someone were to set a notifies on the current resources and providers, they'd fire every time, even if the load balancer or LB node wasn't modified. You'd also get a much nicer why-run mode, where you could tell the chef-run / chef-client if you're really going to make an API call.
I'd challenge you to drop the poise dependencies like https://github.com/theborch/rackspace_lbaas/blob/master/libraries/provider_load_balancer.rb. I don't think you're really taking advantage of anything major, and you'd get one major benefit: true idempotency.
Currently, that provider's actions always run, instead of:
If someone were to set a
notifieson the current resources and providers, they'd fire every time, even if the load balancer or LB node wasn't modified. You'd also get a much nicerwhy-runmode, where you could tell the chef-run / chef-client if you're really going to make an API call.