search

theborch / rackspace_lbaas

Libraries for managing Rackspace Cloud Load Balancers with Chef.
Apache License 2.0
0 stars 0 forks source link

Exceptions in global namespace #3

Open martinb3 opened 9 years ago

martinb3 commented 9 years ago

I noticed there are some exceptions that aren't scoped to any particular class or module: https://github.com/theborch/rackspace_lbaas/blob/master/libraries/helpers.rb#L1-L4

class StatusPendingError < StandardError
end
class StatusError < StandardError
end

These should probably be inside modules whenever possible.