search

thebrandonallen / edit-author-slug

WordPress plugin that allows an admin (or capable user) to edit the author slug of a user, and change the author base. New development takes place on the 'develop' branch.
http://wordpress.org/plugins/edit-author-slug/
GNU General Public License v2.0
41 stars 8 forks source link

Missing labels added #13

Closed sandrowuermli closed 7 years ago

sandrowuermli commented 7 years ago

For those who like to click the text after a checkbox, instead of targeting this small boxes, i added labels.

thebrandonallen commented 7 years ago

Thanks for the PR, and making Edit Author Slug better.

The labels are not, technically, missing. They're located on the table headers, rather than the input descriptions.

You are correct that they should be on the input descriptions to be consistent with the established WP admin patterns.

However, there are some things missing from this commit:

  1. The labels that are added via the Settings API need to be removed
  2. Labels should only wrap the text, not the input as well
  3. There are some white space issues
  4. The for="" attributes are missing from each label

I'll fix these and close this PR with an upcoming commit.