search

thebrightspark / SparksTools

Successor to Sparks Hammers, but now adding all kinds of tools!
GNU General Public License v3.0
0 stars 0 forks source link

[1.12.2] [Suggestion] [Minor incompatibility with other mod] Tools should extend from the vanilla tool class to expand mod compatibility #8

Closed Kenja-mc closed 4 years ago

Kenja-mc commented 4 years ago

Hey, sorry if you don't update the 1.12.2 version of the mod anymore, but I was making a personal modpack and I was trying to use Sparks Tools with Pickletweaks.

As you can see in the issue below, tools from Sparks Tools are not compatible with PickleTweaks because they don't extend from the vanilla tool class.

https://github.com/BlakeBr0/PickleTweaks/issues/54#issuecomment-656965708

I think extending the hammer, excavator, plow and lumberaxe from their vanilla counterparts would do a lot to expand compatibility with other mods.

I'm not very educated on modding with Kotlin, so if this is unfeasible, I apologize.

Kenja-mc commented 4 years ago

I have decided to just attempt to write my own mod rather than make the PR.

image