search

thebrowsercompany / swift-build

Swift toolchain builds by The Browser Company
351 stars 10 forks source link

Support Azure runners by installing WixToolset.Sdk and adding sccache to PATH #144

Closed kendalharland closed 2 months ago

kendalharland commented 3 months ago

This PR triggers the swift-toolchain.yml workflow on pull requests that modify the workflow file. To run on Azure we can update the WINDOWS_BUILD_RUNNER and COMPILERS_BUILD_RUNNER vars in GitHub. These variables also function as the USE_CIRUN kill switch we use in other repos.

Changes

Testing

https://github.com/thebrowsercompany/swift-build/actions/runs/9523625351

compnerd commented 2 months ago

Whitespace and pinning can likely be upstreamed first to reduce the diff.

kendalharland commented 2 months ago

Whitespace and pinning can likely be upstreamed first to reduce the diff.

See https://github.com/compnerd/swift-build/pull/741. Will sync and rebase once that is merged. I'll remove the whitespace to reduce the diff since it's not critical to the PR.

kendalharland commented 2 months ago

I split the .cirun.yml change into https://github.com/thebrowsercompany/swift-build/pull/157 and will rebase

kendalharland commented 2 months ago

Per @tristanlabelle's comment, I've removed the code changes to select the Azure runner images since we can do this by changing the repository's variables.