[Do not merge] Always upload icu-tools binaries

thebrowsercompany / swift-build

Swift toolchain builds by The Browser Company

351 stars 10 forks source link

[Do not merge] Always upload icu-tools binaries #156

Closed z2oh closed 2 months ago

z2oh commented 2 months ago

Debugging a segfault in gencval.exe that only seems to happen in CI. Forcing the upload step to happen even if the build fails so that I can grab the segfaulting binary from the artifact

This kind of change is probably worth applying to all the artifact upload steps. I'll submit a real PR with this change after I debug this

z2oh commented 2 months ago

Cleaned up the changes in https://github.com/thebrowsercompany/swift-build/pull/158