search

thebrowsercompany / swift-webdriver

A Swift library for communicating with WebDriver (Appium/WinAppDriver) endpoints
BSD 3-Clause "New" or "Revised" License
105 stars 3 forks source link

Remove the default retry timeout. #102

Closed tristanlabelle closed 4 months ago

tristanlabelle commented 1 year ago

webdriver-swift should not dictate what is the correct default retry timeout for every testing application. The burden of choosing that magic number should be higher level. This is similar to how the implicit wait timeout in webdriver defaults to zero.

tristanlabelle commented 1 year ago

@jeffdav What do you think of this? (and updating the arc UI tests to set the value)

jeffdav commented 1 year ago

Seems reasonable to me. Should we set it in a test? And didn't we have a constant somewhere, or did that already go away?

tristanlabelle commented 1 year ago

Here was the constant:

image
tristanlabelle commented 4 months ago

Implemented in https://github.com/thebrowsercompany/swift-webdriver/pull/153