Screenshot - Githubissues

thebrowsercompany / swift-webdriver

A Swift library for communicating with WebDriver (Appium/WinAppDriver) endpoints

BSD 3-Clause "New" or "Revised" License

105 stars 3 forks source link

Screenshot #30

Closed jeffdav closed 1 year ago

jeffdav commented 1 year ago

Added screenshot() fn to Session.
Added tests. Note: I'm not adding an actual fixture to test, because that would be dependent on a bunch of display settings being the same to pass. Instead we just check to make sure we got something.
Removed EOL whitespace in the first commit.

tristanlabelle commented 1 year ago

Thanks for fixing the whitespace oddities!

jeffdav commented 1 year ago

@tristanlabelle have a look at latest change. I added a fn to check for the PNG signature. I wanted to share it between tests, and this is the way I could figure out. LMK if there is a better way or if this is fine.

tristanlabelle commented 1 year ago

@jeffdav, yeah that's a clever solution :)

tristanlabelle commented 1 year ago

@jeffdav also, this works in the PR description: Fixes WIN-700