This will retry if we catch winAppDriver_elementNotInteractable. However, if we time out without it succeeding, then we just carry on and a test that does the above will not fail in any explicit way, especially if this is the last thing a test does.
So I think that retryUntil should throw if it times-out. It should either throw the original error, or throw a retry time'd out error with enough context to figure out what failed.
Consider:
This will retry if we catch
winAppDriver_elementNotInteractable. However, if we time out without it succeeding, then we just carry on and a test that does the above will not fail in any explicit way, especially if this is the last thing a test does.So I think that
retryUntilshould throw if it times-out. It should either throw the original error, or throw a retry time'd out error with enough context to figure out what failed.