thebrowsercompany / swift-webdriver

A Swift library for communicating with WebDriver (Appium/WinAppDriver) endpoints
BSD 3-Clause "New" or "Revised" License
105 stars 3 forks source link

Migrate to WebDriver protocol's built-in implicit wait mechanism #69

Open tristanlabelle opened 1 year ago

tristanlabelle commented 1 year ago

We reimplemented implicit waiting but the WebDriver protocol actually provides this functionality:

https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidtimeoutsimplicit_wait https://www.w3.org/TR/webdriver1/#set-timeouts

We should also remove the 1-second default timeout since it is arbitrary. WebDriver rather defaults to no implicit wait and puts the burden on the library user to specify any magic number they want.